Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

BUG: Fix wcs_autolink to work with GWCS #2209

Merged
merged 1 commit into from
Jul 27, 2021
Merged

BUG: Fix wcs_autolink to work with GWCS #2209

merged 1 commit into from
Jul 27, 2021

Conversation

pllim
Copy link
Contributor

@pllim pllim commented Jul 22, 2021

Pull Request Template

Description

This is so wcs_autolink works when Data.coords contains GWCS. cc @astrofrog

@pllim
Copy link
Contributor Author

pllim commented Jul 22, 2021

Failure in Python 3.6 seems unrelated:

ERROR: Could not find a version that satisfies the requirement pandas>=1.2 (from glue-core[test]) (from versions: 0.1, 0.2b0, 0.2b1, 0.2, 0.3.0b0, 0.3.0b2, 0.3.0, 0.4.0, 0.4.1, 0.4.2, 0.4.3, 0.5.0, 0.6.0, 0.6.1, 0.7.0, 0.7.1, 0.7.2, 0.7.3, 0.8.0rc1, 0.8.0, 0.8.1, 0.9.0, 0.9.1, 0.10.0, 0.10.1, 0.11.0, 0.12.0, 0.13.0, 0.13.1, 0.14.0, 0.14.1, 0.15.0, 0.15.1, 0.15.2, 0.16.0, 0.16.1, 0.16.2, 0.17.0, 0.17.1, 0.18.0, 0.18.1, 0.19.0, 0.19.1, 0.19.2, 0.20.0, 0.20.1, 0.20.2, 0.20.3, 0.21.0, 0.21.1, 0.22.0, 0.23.0, 0.23.1, 0.23.2, 0.23.3, 0.23.4, 0.24.0, 0.24.1, 0.24.2, 0.25.0, 0.25.1, 0.25.2, 0.25.3, 1.0.0, 1.0.1, 1.0.2, 1.0.3, 1.0.4, 1.0.5, 1.1.0, 1.1.1, 1.1.2, 1.1.3, 1.1.4, 1.1.5)
ERROR: No matching distribution found for pandas>=1.2

@codecov
Copy link

codecov bot commented Jul 22, 2021 •
edited
Loading

Codecov Report

Merging #2209 (be91c02) into master (ad14432) will decrease coverage by 0.02%.
The diff coverage is 100.00%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master    #2209      +/-   ##
==========================================
- Coverage   88.03%   88.00%   -0.03%     
==========================================
  Files         247      247              
  Lines       22968    22967       -1     
==========================================
- Hits        20219    20213       -6     
- Misses       2749     2754       +5
Impacted Files Coverage Δ
glue/plugins/wcs_autolinking/wcs_autolinking.py 97.52% <100.00%> (-0.03%) ⬇️
glue/viewers/common/state.py 84.21% <0.00%> (-10.53%) ⬇️
glue/conftest.py 59.09% <0.00%> (-3.04%) ⬇️
glue/core/layer_artist.py 80.00% <0.00%> (-0.58%) ⬇️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update ad14432...be91c02. Read the comment docs.

astrofrog
astrofrog approved these changes Jul 22, 2021
View reviewed changes
Copy link
Member

@astrofrog astrofrog left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good catch!

@astrofrog
Copy link
Member

@pllim fancy adding a regression test? :)

@pllim
Copy link
Contributor Author

pllim commented Jul 22, 2021

regression test

Not sure how to do that without introducing a dependency to GWCS.

@pllim
Copy link
Contributor Author

pllim commented Jul 22, 2021

Also, looks like your CI is busted.

@astrofrog astrofrog merged commit bb2e8b3 into glue-viz:master Jul 27, 2021
@pllim pllim deleted the gwcs-autolink branch July 27, 2021 13:18
@pllim pllim mentioned this pull request Aug 11, 2021
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@astrofrog astrofrog astrofrog approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@pllim @astrofrog